Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Show loader in docs app #15280

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Oct 17, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
update to the docs app

What is the current behavior? (You can also link to an open issue here)
No loader is displayed when changing views in the docs

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@Narretz Narretz force-pushed the chore-docs-app-loader branch from 2ccb576 to 849a9b9 Compare October 17, 2016 13:54
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@Narretz Narretz added this to the Backlog2 milestone Oct 17, 2016
@Narretz Narretz changed the title Chore docs app loader Show loader in docs app Oct 17, 2016
@petebacondarwin
Copy link
Contributor

LGTM

@Narretz Narretz merged commit 1997360 into angular:master Oct 17, 2016
Narretz added a commit that referenced this pull request Oct 17, 2016
@gkalpak gkalpak modified the milestones: Backlog, Backlog2 Oct 19, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
petebacondarwin pushed a commit to petebacondarwin/angular.js that referenced this pull request Nov 21, 2016
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants